search

Eyepea / aiosip

SIP support for AsyncIO (DEPRECATED)
Apache License 2.0
82 stars 40 forks source link

Temporarily add dialog with None tag to dialogs list #118

Closed ovv closed 6 years ago

ovv commented 6 years ago

Some request can come without a To headers tag (after a 401 for example). This should probably be done only for specific status code.

Also catch asyncio.CancelledError of dialog._closing

codecov-io commented 6 years ago

Codecov Report

Merging #118 into master will increase coverage by 0.19%. The diff coverage is 70.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
+ Coverage   71.48%   71.68%   +0.19%     
==========================================
  Files          15       15              
  Lines        1487     1501      +14     
  Branches      256      257       +1     
==========================================
+ Hits         1063     1076      +13     
- Misses        316      317       +1     
  Partials      108      108
Impacted Files Coverage Δ
aiosip/application.py 72.61% <0%> (+0.45%) :arrow_up:
aiosip/peers.py 78.69% <100%> (+0.09%) :arrow_up:
aiosip/utils.py 46.8% <66.66%> (+3.21%) :arrow_up:
aiosip/dialog.py 76.25% <83.33%> (+0.82%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8a2a81e...f4d0a5e. Read the comment docs.