search

Eyepea / aiosip

SIP support for AsyncIO (DEPRECATED)
Apache License 2.0
82 stars 40 forks source link

Request #119

Open ovv opened 6 years ago

ovv commented 6 years ago

What do you think of an approach like that for the Request @vodik ?

This is based on #118 only the last commit is relevant

codecov-io commented 6 years ago

Codecov Report

Merging #119 into master will increase coverage by 0.33%. The diff coverage is 80.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   71.48%   71.82%   +0.33%     
==========================================
  Files          15       15              
  Lines        1487     1512      +25     
  Branches      256      257       +1     
==========================================
+ Hits         1063     1086      +23     
- Misses        316      318       +2     
  Partials      108      108
Impacted Files Coverage Δ
aiosip/peers.py 78.69% <100%> (+0.09%) :arrow_up:
aiosip/utils.py 46.8% <66.66%> (+3.21%) :arrow_up:
aiosip/application.py 72.14% <75%> (-0.01%) :arrow_down:
aiosip/dialog.py 76.75% <84.21%> (+1.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8a2a81e...58a9b3f. Read the comment docs.

vodik commented 6 years ago

I really like it. I was always planning on going back to do this.

As for #118 - I forgot app is attached to the request, so its actually really simple.

vodik commented 6 years ago

I'm going to try merging this and #121 on a private branch and see how well it works for me.