Closed ovv closed 6 years ago
Merging #126 into master will increase coverage by
0.04%
. The diff coverage is92.3%
.
@@ Coverage Diff @@
## master #126 +/- ##
==========================================
+ Coverage 71.68% 71.73% +0.04%
==========================================
Files 15 15
Lines 1501 1507 +6
Branches 257 259 +2
==========================================
+ Hits 1076 1081 +5
Misses 317 317
- Partials 108 109 +1
Impacted Files | Coverage Δ | |
---|---|---|
aiosip/peers.py | 78.81% <92.3%> (+0.11%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 89dc7d2...d5d2629. Read the comment docs.
No problem with this, but I think between this, some of my musings, and some of the points from the PDF that @GMLudo linked, I'm really starting to think the relationship between Application and Peer is backwards.
I need to mull on it a bit more so I can write a coherent proposal, but think I should put the idea out again.
Let's merge that and we will see when we rewrite peer to have a better handling of peer & application
I had to test something with multiple connection and quickly put that together. Since dialogs are not tracked by peer anymore it should work but I'm not sure there are no side effect.
I'll try to do some more tests on it soon.