[WIP] Ambitious rework of dialogs, transactions, and useragents.

Eyepea / aiosip

SIP support for AsyncIO (DEPRECATED)

Apache License 2.0

82 stars 40 forks source link

[WIP] Ambitious rework of dialogs, transactions, and useragents. #127

Closed vodik closed 5 years ago

vodik commented 6 years ago

Putting this up for review mostly so people can have an early look at what I'm doing now - this is both far from working and far from complete.

Most of the ideas here are coming from the paper @GMLudo posted, with a few tweaks.

vodik commented 6 years ago

Okay, so the rough design I'm going to take right now is to try and keep things the same as much as possible but to:

Remove my Request class and replace it with a ServerTransaction/InviteServerTransaction class.
Client side will do something similar as well where on a peer you can trigger the creation of a ClientTransaction/ClientServerTransaction
The Transaction, once completed, will establish a dialog for further in-dialog messages.

Next I'm going to dig into it to see how much sense it might make to replace the Peer with a UAS/UAC interface instead.

ovv commented 6 years ago

I did a quick pass on the code it look very nice :+1:

You have a better SIP knowledge than me so I trust your architectural choice

ludovic-gasc commented 6 years ago

I like this new approach ;-)

ovv commented 6 years ago

@vodik Hey. I don't want to push you but do you have any idea when/if we could merge this PR ? I would like to work a bit on aiosip but I think it would be best to wait for this big rework to land in master first.

vodik commented 5 years ago

Okay, all feedback acknoledged. I'm going to close this and start over, as I've both lost my train of though and the code base had changed enough that rebasing is kinda difficult.