Jane-Fan commented 5 years ago

This pull request cherry pick the sip auth fix from #125 since it is needed for our testing. The unit test is added to verify the expected digest response.

codecov-io commented 5 years ago

Codecov Report

Merging #130 into master will increase coverage by 0.31%. The diff coverage is 73.91%.

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   72.46%   72.77%   +0.31%     
==========================================
  Files          15       15              
  Lines        1551     1554       +3     
  Branches      268      266       -2     
==========================================
+ Hits         1124     1131       +7     
+ Misses        315      314       -1     
+ Partials      112      109       -3

Impacted Files	Coverage Δ
aiosip/auth.py	`78.51% <73.91%> (+3.93%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e62e996...a72237d. Read the comment docs.

vodik commented 5 years ago

I'm just going to quickly tweak this and get it merged upstream. I want to change the stringy handling of authentication schemes to use an enum.

This currently won't crash when we see an unsupported authentication scheme, which was part of the problem in the first place. If it has crashed then, we would have been able to fix this a lot faster.

ovv commented 5 years ago

@vodik I'm glad to see you are back & I hope everything is ok.

Just to let you know what we have been up to, I recently took a bit of time to work on the client to imagine and test an API that would work nicely. You can find that there (https://github.com/Eyepea/aiosip/compare/client) . It breaks a lot of things since I only wanted to experiment but it might be interesting for your dialog work. The test.py file contains a working example

Eyepea / aiosip

Registration fix #130

Codecov Report