rockwelln commented 5 years ago

In python3.7, importing MutableMapping directly from collections raise a deprecation warning:

>>> from collections import MutableMapping
__main__:1: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

Importing from collections.abc solve the warning :-)

P.S MutableMapping is part of collections.abc since 3.3

codecov-io commented 5 years ago

Codecov Report

Merging #132 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #132   +/-   ##
=======================================
  Coverage   72.77%   72.77%           
=======================================
  Files          15       15           
  Lines        1554     1554           
  Branches      266      266           
=======================================
  Hits         1131     1131           
  Misses        314      314           
  Partials      109      109

Impacted Files	Coverage Δ
aiosip/contact.py	`67.14% <100%> (ø)`	:arrow_up:
aiosip/uri.py	`71.92% <100%> (ø)`	:arrow_up:
aiosip/via.py	`66.66% <100%> (ø)`	:arrow_up:
aiosip/auth.py	`78.51% <100%> (ø)`	:arrow_up:
aiosip/application.py	`72.61% <100%> (ø)`	:arrow_up:
aiosip/param.py	`90% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3279d70...2517602. Read the comment docs.

ovv commented 5 years ago

Thanks :+1:

Eyepea / aiosip

import MutableMapping from collections.abc #132

Codecov Report