Eyepea / aiosip

SIP support for AsyncIO (DEPRECATED)
Apache License 2.0
83 stars 42 forks source link

Server auth + user-agent + improve routing #25

Closed ovv closed 7 years ago

ovv commented 7 years ago

Each dialog / user in the dialplan can have a separate router (MutabbleMapping)

Authentification works by calling a callback given as app creation and expect a boolean response

ludovic-gasc commented 7 years ago

LGTM to me. @vodik is OK for you ?

ovv commented 7 years ago

Don't merge yet I thought of a few things I should improve on the drive home.

vodik commented 7 years ago

Looks great to me, can we merge it? Awesome work.

ovv commented 7 years ago

It's still rough but I think it can be merged. Especially if you want to build on it for the transaction PR

vodik commented 7 years ago

Cool, yeah, I'd like to get that in because I want to shift focus to writing a test suite for a bit, and then look at refactoring.

vodik commented 7 years ago

Oh, I didn't notice this before I merged it, but async keyword has leaked in. You guys decide officially to drop 3.4 support?

ovv commented 7 years ago

Out of habit :)

I'm ok on dropping 3.4 and @GMLudo should be too. What about you ?