search

Eyepea / aiosip

SIP support for AsyncIO (DEPRECATED)
Apache License 2.0
82 stars 41 forks source link

[websockets] specify 'sip' subprotocol #58

Closed jlaine closed 6 years ago

jlaine commented 6 years ago

This ensure the appropriate Sec-WebSocket-Protocol header is set.

Some browsers strictly enforce subprotocol selection and will close the WebSocket if they do not receive the correct Sec-WebSocket-Protocol.

codecov-io commented 6 years ago

Codecov Report

Merging #58 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   27.51%   27.51%           
=======================================
  Files          15       15           
  Lines        1443     1443           
  Branches      259      259           
=======================================
  Hits          397      397           
  Misses       1033     1033           
  Partials       13       13
Impacted Files Coverage Δ
aiosip/peers.py 20.15% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a26d3ac...5000151. Read the comment docs.