Closed vodik closed 6 years ago
Merging #71 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #71 +/- ##
=======================================
Coverage 71.45% 71.45%
=======================================
Files 15 15
Lines 1461 1461
Branches 262 262
=======================================
Hits 1044 1044
Misses 311 311
Partials 106 106
Impacted Files | Coverage Δ | |
---|---|---|
aiosip/peers.py | 69.4% <ø> (ø) |
:arrow_up: |
aiosip/application.py | 67.04% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3868c99...e530dc7. Read the comment docs.
I'll see if I can add a test for this.
At the very least, I might merge it without as it enables my b2bua example to work :wink:
Our subscribe example works, but it provides a From header with a port that doesn't match where the traffic actually came from.
Now since the Contact header is correct, its technically valid, but they really should match in this simple scenario (there's no proxy) and it really should be something specifiable.