search

Eyepea / aiosip

SIP support for AsyncIO (DEPRECATED)
Apache License 2.0
82 stars 41 forks source link

Improve subscription example #75

Closed vodik closed 6 years ago

vodik commented 6 years ago

Forgot to fix up the examples with #74

This PR fixes and improved the subscription example.

Instead of sending a fixed number of messages, we'll keep sending them forever until an unsubscribe message arrives. Should also properly handle unsubscribe events.

Still need to add some logic that we stop the subscription if it expires, but still a notable improvement over what was there before.

And to showcase this, the client can now set the duration they'd like to subscribe for, in seconds.

codecov-io commented 6 years ago

Codecov Report

Merging #75 into master will increase coverage by 0.7%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #75     +/-   ##
=========================================
+ Coverage   69.74%   70.45%   +0.7%     
=========================================
  Files          15       14      -1     
  Lines        1494     1479     -15     
  Branches      262      260      -2     
=========================================
  Hits         1042     1042             
+ Misses        342      327     -15     
  Partials      110      110

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 82c9153...4b7dde6. Read the comment docs.