codecov-io
commented
6 years ago Codecov Report
Merging #90 into master will decrease coverage by
0.68%. The diff coverage is49.15%.
@@ Coverage Diff @@
## master #90 +/- ##
==========================================
- Coverage 71.32% 70.63% -0.69%
==========================================
Files 14 14
Lines 1517 1553 +36
Branches 264 273 +9
==========================================
+ Hits 1082 1097 +15
- Misses 328 340 +12
- Partials 107 116 +9| Impacted Files | Coverage Δ | |
|---|---|---|
| aiosip/application.py | 68.3% <0%> (-0.98%) |
:arrow_down: |
| aiosip/peers.py | 68.26% <18.18%> (-0.61%) |
:arrow_down: |
| aiosip/dialog.py | 74.38% <58.69%> (-3.01%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 28b05ff...1cde787. Read the comment docs.
Lots of bug fixes to issues I've identified after developing a small SIP stack on top of my previous aiosip work.
I ended up, after a lot of playing a lot with this library, taking a new approach to SIP testing.
As an aside, instead of trying to mirror the approach of SIPp, instead put in a SIP stack that handles a lot of default traffic flows by default. But also provide an ability to hook in and override handlers with custom behaviour.
CANCEL handling is still a little flaky, but its enough to deliver what I needed to get done for work and free up my time to try and improve things here further.