Peer statistics were removed. Should they be restored?

Eyepea / aiosip

SIP support for AsyncIO (DEPRECATED)

Apache License 2.0

82 stars 41 forks source link

Peer statistics were removed. Should they be restored? #97

Open vodik opened 6 years ago

vodik commented 6 years ago

So #94 pulled out the Peer's contact/registered/subscriber attributes.

I've never personally found them useful, and have always implemented them myself in my REGISTER and SUBSCRIBE handlers - especially since different projects of mine do them slightly differently.

Should we restore them? Drop it?

vodik commented 6 years ago

If you guys relied on them, I don't mind putting in the effort to restore them.

ovv commented 6 years ago

I'm not sure we need them with the dialog rework, we probably don't need to re add them for the moment.

I'm going to get back into aiosip for a project and probably make some improvements / bugfix for what I need. I'll also try to put the releases into travis so that will be easier for everybody

vodik commented 6 years ago

Nice, works for me.