Eyevinn / whip

Client and Server modules for WebRTC HTTP Ingestion Protocol (WHIP)
Apache License 2.0
90 stars 15 forks source link

Syntax of bearer token is incorrect #128

Open jech opened 1 year ago

jech commented 1 year ago

Section 4.5 of draft-ietf-wish-whip-08 says:

WHIP endpoints and resources MAY require the HTTP request to be authenticated using an HTTP Authorization header field with a Bearer token as specified in [RFC6750] section 2.1.

Section 2.1 of RFC 6750 specifies the syntax as:

credentials = "Bearer" 1*SP b64token

So lines 8 and 18 of WhipProtocol.ts should say

                "Authorization": "Bearer " + authKey
birme commented 1 year ago

Thanks! You are absolutely correct. We will address this after the summer break unless anyone else wants to provide a PR