Eyevinn / whip

Client and Server modules for WebRTC HTTP Ingestion Protocol (WHIP)
Apache License 2.0
94 stars 15 forks source link

HTTP request error handling #130

Open friday opened 11 months ago

friday commented 11 months ago

On the demo package ingest page (ex https://web.whip.eyevinn.technology/) we are not showing any error message if the connection fails. Some ad blockers (like Brave browsers defaults) are blocking cross-site requests to localhost/and or 127.0.0.1 etc from other domains even if the browser actually allows them without CORS issues.

Maybe it would be better to be able to handle/catch these as WHIPClient events, and use that from the demo page to show some modal?

They are thrown from https://github.com/Eyevinn/whip/blob/7789d20912000a9389089cd881b6afbae1bd97c7/packages/sdk/src/WHIPProtocol.ts#L15

Possibly related to #106