Ezard / semantic-prs

A GitHub app to check that pull requests follow the Conventional Commits spec
MIT License
110 stars 12 forks source link

Merge queues are not supported #406

Open edgarrmondragon opened 10 months ago

edgarrmondragon commented 10 months ago

Describe the bug

When adding a PR to a merge queue in a repo where this check is required according to branch protection rules, it hangs with "Waiting for status to be reported".

I think the fix could be as simple as triggering this check on a pull_request.enqueued event.

Thanks!

semantic.yml contents

# Config ref: https://github.com/Ezard/semantic-prs

# Validate the PR title, and ignore all commit messages
titleOnly: true

# Provides a custom URL for the "Details" link, which appears next to the success/failure message from the app:
targetUrl: https://docs.meltano.com/contribute/merge#semantic-prs

# The values allowed for the "type" part of the PR title/commit message.
# e.g. for a PR title/commit message of "feat: add some stuff", the type would be "feat"
types:
  - ci
  - chore
  - build
  - break
  - change
  - docs
  - feat
  - fix
  - perf
  - refactor
  - revert
  - style
  - test

# The values allowed for the "scope" part of the PR title/commit message.
# e.g. for a PR title/commit message of "feat(awesome-feature): add some stuff",
#      the scope would be "awesome-feature"
scopes:
  - core
  - cli
  - cloud
  - deps
  - deps-dev

Sample PR Title(s) (if relevant)

No response

Sample Commit Message(s) (if relevant)

No response

Ezard commented 10 months ago

Thanks for raising this @edgarrmondragon!

Not sure how I can test this myself, so I'll add that new event in, and then if you could verify that everything is working on your side then that'd be great 🙂

edgarrmondragon commented 10 months ago

@Ezard Sounds good!

szechyjs commented 6 months ago

Any updates here?

The latest probot beta, finally has support for merge_queue events.

Ezard commented 6 months ago

Thanks for the heads-up @szechyjs, I've started looking into this again 🙂

Ezard commented 6 months ago

Based on the failing tests in the linked PR, it looks like there might've been some other underlying changes in v13 of Probot, so this might need to wait until they supply migration details for this version