search

EzerIT / BibleOL

Web-based instruction in Biblical Hebrew and Greek
Other
26 stars 16 forks source link

Exercise duration being saved as 0 or less than 0 #18

Closed cascav4l closed 10 months ago

cascav4l commented 10 months ago

When taking an exam, some students' exercise duration seems to be saving as a value that is less than or equal to 0. This then results in a divide by 0 error when trying to calculated the features per minute.

mabioc commented 10 months ago

We have seen this on the past, in occasion, the start time and end time have the same value (what should not be, because when we subtract end time by start time we got zero), which cause a division by zero on the code (both legacy BibleOL code and on the grading code). Somebody has to investigate why the server code that record the exam is failing in at random times.

oliverglanz commented 10 months ago

This error is not exam related! It appears with exercises as well. It seems to result from a bug in the original BibleOL code that is responsible for recording exercises. To give an example:

This quiz was taken by students: https://learner.bible/text/show_quiz?quiz=Andrews%20University%2FJAM_Test%2FHebrew-02_01_SDATS_Vocabulary%20midterm.3et&count=10

When the instructor goes to MY DATA/Students' performance/ and then selects that particular exercise to show the graphs it shows this:

image

When this error mesage appears here (under Students' performance) it will also create error messages for the grading module and the exam module as those modules rely on the same data storing code that "Students' performances relies on. To demonstrate this: When you go to "Grade Quizzes" and select that particular exercise from above you get the same error message:

image

THis in turn will create the same error message when that exercise was part of an exam and the DivisionByZeroError occured.

oliverglanz commented 10 months ago

Here is a short screen recording that shows the issue: https://drive.google.com/file/d/1Fwn_smnEhO0TLwGRVnjpDhATlb0LjwMK/view?usp=sharing

tmccormack165 commented 10 months ago

This issue was resolved in: Set minimum exercise duration to 1 second and Fix the division by zero issues

The root cause was solved by setting a minimum duration for all exercises within an exam.

mabioc commented 10 months ago

Thank you Tim.

On Tue, Nov 7, 2023, 9:37 AM tmccormack165 @.***> wrote:

Closed #18 https://github.com/EzerIT/BibleOL/issues/18 as completed.

— Reply to this email directly, view it on GitHub https://github.com/EzerIT/BibleOL/issues/18#event-10887798620, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD4BYIZ66JPQISXV27BLQ3YDJBTVAVCNFSM6AAAAAA6PVJ5ZCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQHA4DONZZHA3DEMA . You are receiving this because you commented.Message ID: @.***>