EzerIT / BibleOL

Web-based instruction in Biblical Hebrew and Greek
Other
26 stars 16 forks source link

Remove yellow shaddow when editing exercise #24

Closed ernstboogert closed 11 months ago

ernstboogert commented 1 year ago

When editing an exercise, there are weird yellow shadows... These might be the result of a css theme used in the past. Please remove...

image

ernstboogert commented 1 year ago

Hi @tmccormack165, it happens to be the case also with the My View button; please see the screenshot below...

image

dgurtner commented 11 months ago

I would be happy to contribute a fix for this. It looks like a it's a background in /jquery-ui-1.13.2.custom/jquery-ui.min.css. Let me know how I can help. Screen Shot 2023-12-21 at 9 44 33 PM Screen Shot 2023-12-21 at 9 42 01 PM

tmccormack165 commented 11 months ago

Hi @dgurtner, thank you very much for your solution. Section 3.2.1 of techdoc/techdoc.pdf outlines how to fork the main BibleOL repository. From there, you can add your changes to your forked changes and then hit "Contribute" to make a Pull Request, when you do that please include me as a reviewer. Then, I will be happy to update our server on learner.bible with your solution if the edits are cohesive with the system.

Sincerely, Timothy

Screenshot 2023-12-24 at 12 39 01 PM
tmccormack165 commented 11 months ago

Hi everyone, thanks to @dgurtner input, I believe we have a working solution now:

There are yellow shadows in two places on the system that need to be removed.

The first occurrence is when an exercise is being created:

Screenshot 2023-12-24 at 1 21 43 PM

The second occurrence is when a student is taking an exam or exercise and clicks on "My View":

Screenshot 2023-12-24 at 1 25 47 PM

To remove these shadows I changed the padding-right attribute of .ui-tabs in ol.css:401 and ol.css:405 from 5px to 0px:

.ui-tabs .ui-tabs-nav .ui-state-default {
  border: none;
  padding-right: 0px;
}
.ui-tabs .ui-tabs-nav .ui-state-active {
  border: none;
  padding-right: 0px;
}

The edit deletes the yellow shadows:

Screenshot 2023-12-24 at 1 29 23 PM Screenshot 2023-12-24 at 1 28 39 PM

Edits:

Screenshot 2023-12-24 at 1 33 11 PM
dgurtner commented 11 months ago

I like your solution and I'm glad I could help!