search

Ezka77 / xen-orchestra-ce

:whale: Docker & docker-compose files to deploy Xen Orchestra Community Edition (ie: from sources)
GNU General Public License v3.0
98 stars 35 forks source link

Allow HTTP/HTTPS configuration via environment variables #35

Closed andrewheberle closed 4 years ago

andrewheberle commented 4 years ago

This PR introduces configuration of /etc/xo-server/config.toml via remco, a lightweight configuration manager so values such as the HTTP port and enabling HTTPS can be managed by environment variables.

Remco also replaces tini as PID 1 in the container to execute rpcbind and xo-server and keep them running.

An example for usage has been added to the README and healthcheck.js has been updated to use the HTTP env var value for its check.

The naming of the environment variables are loosely based on the names in the config.toml for xo-server.

This PR also removes EXPOSE 8000 in the Dockerfile as this port is no longer hard coded (although the default is still 8000).

Ezka77 commented 4 years ago

Hi, First thanks for your PR. It's quite handy to be able to configure XOA via env vars, until now I usually advise people in need to use HTTPS to build their proxy for that (well they still can anyway). May I ask you to squash your 11 commits into one ? this as I think it's more relevant to get one functionality per commit and it makes history easier to read (for a revert or whatever).

andrewheberle commented 4 years ago

May I ask you to squash your 11 commits into one

All done, thanks.