search

Ezriilc / HyperEdit

A plugin for Kerbal Space Program.
http://www.Kerbaltek.com/hyperedit
GNU General Public License v3.0
41 stars 30 forks source link

Lander is behaving as if coordinates are different now in KSP 1.3.1 #29

Closed Ezriilc closed 6 years ago

Ezriilc commented 6 years ago

The behavior is strange, and makes the Lander unusable. It tends to put the ship inside the planet and/or just makes it explode with very strange results in the map view.

This particular problem seems entirely new with KSP 1.3.1, and not at all like previous quirks of the Lander, which one could work around.

Ezriilc commented 6 years ago

@fronbow I noticed that hitting the "current" button places the asl altitude in the coordinates box, not the agl value. So if you hit "current" and then "land" you end up in a different spot (altitude-wise) from where you started.

This was what I noticed a while back. It would be good to fix that.

wile1411 commented 6 years ago

awesome! I'll still test, but the latest beta sounds like it got to two things I noticed. Great work!

Ezriilc commented 6 years ago

Yes, kudos all around.

fronbow commented 6 years ago

@chrisverwey @wile1411 @Ezriilc And here's me thinking we could get a release out the door soon ;) I'm not very good at planes ;) well, getting them into the air so I never think to try with them! Back to testing asl/agl then. At least the runway will make for a change of scenery ;)

fronbow commented 6 years ago

@chrisverwey I noticed that hitting the "current" button places the asl altitude in the coordinates box, not the agl value. So if you hit "current" and then "land" you end up in a different spot (altitude-wise) from where you started.

So it should be the AGL not ASL that shows in the Lander window? KSP doesn't make distinguishing between them both very easy!

Ezriilc commented 6 years ago

Oh, BTW, someone asked why anyone would want to "Land" very far above the surface. I sometimes use a very high drop as a way to test airplanes without needing to take off normally. I also was toying with the idea of having the Lander impart horizontal speed to the craft as it is dropped, and I realize that that may open a large can of worms.

wile1411 commented 6 years ago

@Ezriilc Imparting horizontal speed is easy! Just set your obit to an altitude of 10K and you'll have all the speed you'll ever need :-P (Great idea though! If you do that, it might be prudent to put a max limit of how much speed you can add to a spawning craft to avoid above situation)

fronbow commented 6 years ago

@Ezriilc ah yes, that makes sense, did I mention I don't really play with aircraft?! Yes, that will open a can of worms, maybe even a kraken or two ;) Stick it down as a possible feature request.

Ezriilc commented 6 years ago

Yea, ha! Or, make the velocity a changeable setting, which would allow the player to test how much their craft can handle.

Ezriilc commented 6 years ago

"Release the Kraken!" https://github.com/Ezriilc/HyperEdit/issues/35

fronbow commented 6 years ago

lol, I bet you could break KSP that way. I'll look at that feature request another day!!

Ezriilc commented 6 years ago

I just want to say thanks to you all again. This has been fun!

I've said it before, and I'll say it again: Best... community... EVER.

Ezriilc commented 6 years ago

I'm looking to you all to tell me explicitly, and/or send a final pull request for a full release.

fronbow commented 6 years ago

I just ahem "warped" around the Kerbal Solar system and it all seems to be ok, no crashes or terrain collides. Pull request should be with you asap.

wile1411 commented 6 years ago

whatever you do, I'll test the latest in 11hrs.

Ezriilc commented 6 years ago

I've just done a "final" test, and I see that the Lander's difference between "Current" alt and what you get with "Land" is still wrong. I guess I thought that was fixed today. Technically it wasn't part of this issue, so if it's not an easy fix, then I'll just create a new issue for it and we'll get it next round.

To reproduce: Load and launch the "AeroEquus" rocket to the pad. In the Lander, click "Current" and see that it reads the alt as ~83. Then click "Land" and see that it puts you far above the pad (83m?). But, if you change that alt to 1, it puts you down on the surface more or less immediately.

EDIT: I'm still going to publish what we have as BETA-4, pending this or any other issues coming to light and/or getting fixed. EDIT: EDIT: I've decided to leave it at the BETA-3 since (w/o the alt fix) that seems to be up to date with our code.

fronbow commented 6 years ago

Yeah it's still the AGL vs ASL. It's time-consuming hunting it down. I would consider it a different issue as we seem to have got the lat/lon/alt working better :)

Ezriilc commented 6 years ago

Fair enough! This issue is DONE! Again, well done, and thanks to everyone. EDIT: Derp! We already have the alt issue: https://github.com/Ezriilc/HyperEdit/issues/15