Closed fronbow closed 6 years ago
Yeah I'll split them off (I was trying something to package it up)
I removed the whole Assets directory.
On 21 December 2017 at 23:08, Ezriilc notifications@github.com wrote:
@Ezriilc requested changes on this pull request.
I think settings and other extras should remain out of the code repo.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Ezriilc/HyperEdit/pull/36#pullrequestreview-85206813, or mute the thread https://github.com/notifications/unsubscribe-auth/ABWhOwHnVtxO7boqfoR3uDxR3HkdsvQxks5tCuTygaJpZM4RKc3g .
--
@fronbow [Martin Frost]
So, should I just merge this now? Is it better to squash and merge?
You can delete this pull and I'll initiate a cleaner one!
On 21 December 2017 at 23:14, Ezriilc notifications@github.com wrote:
So, should I just merge this now? Is it better to squash and merge?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Ezriilc/HyperEdit/pull/36#issuecomment-353481308, or mute the thread https://github.com/notifications/unsubscribe-auth/ABWhO3PN_rLdFHU7FDDdhMr7rcDI34lwks5tCuZPgaJpZM4RKc3g .
--
@fronbow [Martin Frost]
Here you go :)