Ezriilc / HyperEdit

A plugin for Kerbal Space Program.
http://www.Kerbaltek.com/hyperedit
GNU General Public License v3.0
41 stars 30 forks source link

Lander coords not exactly stable over time. #41

Open Ezriilc opened 6 years ago

Ezriilc commented 6 years ago

To reproduce:

fronbow commented 6 years ago

I have a feeling I know what causes this; but as a general ask, what do you think should happen?

  1. Should we attempt to land in exactly the same spot as a possible existing craft?
  2. Or??

I imagine I'm creating a bit more work for myself if the answer is 1 as I'll need to check why the I,J,K,L keys don't work as they're supposed to for fine-tweaking landing.

Ezriilc commented 6 years ago

Number 1, for sure. That, combined with the lateral adjustments available via JKLI, makes for a flexible, yet yet still controllable Landing.

fronbow commented 6 years ago

Okies, I'll look at that next!

fronbow commented 6 years ago

I think I've solved this in my latest build! Though due to the nature of coords, the 2nd vessel doesn't spawn on top of the previous one, but a few metres away which feels a lot better.

Ezriilc commented 6 years ago

Can we increase the precision of our coords to make it perfect? I think it's very important that HE does exactly as it's told. The JKLI keys can be used if the user wishes to avoid an existing ship. This is important for various reasons, like building bases.

fronbow commented 6 years ago

Yes, I removed the logic that was trying to add 50m to the coords so now it uses the exact same coords. So using my moho test.

Two Stage Lander:
Lat: -0.000113031145345185
Lon: -171.65461843275

Orbiter 1A:
Lat: -0.000113031145345185
Lon: -171.65461843275

These are the numbers returned by using Current on the Lander. KSPEngineer reports that the first one is at 171" 39' 16 W and the second craft is at 171" 39' 45 W which makes me think time factors in somehow as the precise values are exactly the same! Maybe we need to change the advertisement to "can land you in the same major grid coords"?!!

fronbow commented 6 years ago

Did a few more tests recently and the coords do seem to change based on time, and also based on the time the craft launched. Obviously I need to do more testing to find a way of "fixing" this if it's possible!!

Ezriilc commented 6 years ago

It seems hard to believe that there is/are no API value(s) to hook onto.

In the worst case, perhaps can we count/track the change(s) over time to end up with the same thing the game does.