Ezriilc / HyperEdit

A plugin for Kerbal Space Program.
http://www.Kerbaltek.com/hyperedit
GNU General Public License v3.0
41 stars 30 forks source link

Add Support for kRPC to hyperedit #49

Open arthurp opened 6 years ago

arthurp commented 6 years ago

It would be useful to be able to use hyperedit to set orbits and the like from kRPC. It would allow for debugging scripts and (in my interest) quickly getting into a known state for machine learning training runs.

It looks like all that would be needed would be some annotations or at worst a wrapper class or two. KRPC documents the annotations here: https://krpc.github.io/krpc/extending.html

Ezriilc commented 6 years ago

I would need to consider this carefully to see if it is a good match for HyperEdit. I don't really use mods other than HyperEdit and Mech Jeb, so I'm not familiar.

If you know C#, it would very helpful to get a sample build to put up as a BETA version.

Ezriilc commented 6 years ago

@arthurp , thanks for the suggestion, BTW. I dunno how to send a direct message in GitHub, but I'd like to discuss other help we need, if you're game. I'm in the forum, on IRC, and of course my site. http://www.Kerbaltek.com/contact

arthurp commented 6 years ago

@Ezriilc I don't think there are direct messages on github. And for open-source projects having all dev discussions in the open is generally a good policy.

That said I don't have time to help much. I'm in grad school. ;-) However I will try to put together a pull request for you. You can then release it as a beta if you like. I don't want to get into the business of releasing anything myself, I don't have the time to make sure I do it right.

I'll start working on the PR some time next week (I'm in Portugal at the moment).

Ezriilc commented 6 years ago

I understand, of course. I do appreciate your attention, but don't worry about sending a PR if you're busy. There is no urgency here.

arthurp commented 6 years ago

Well I want this feature!!! ;-) And it's only polite to have PR ready as soon as I get it prototyped for myself.