search

Ezriilc / HyperEdit

A plugin for Kerbal Space Program.
http://www.Kerbaltek.com/hyperedit
GNU General Public License v3.0
41 stars 30 forks source link

Revert PR #56. #60

Closed sworisbreathing closed 5 years ago

sworisbreathing commented 5 years ago

This should get #52 back to where it was before I messed things up. It reverts #56.

craidler commented 5 years ago

Makes #57 & #58 obsolete

Ezriilc commented 5 years ago

@sworisbreathing : I'm not sure that it was you that triggered this, as I was doing several things (merging another branch after your PR) that I don't properly know how to do, all at once. I'm going to leave this here, until we see what I've done and how that may get fixed.

But, don't think I don't appreciate all you've done. Once we get back to "normal", I do want to add your contributions to fix up on our Planet Editor bug(s).

Thanks again!

sworisbreathing commented 5 years ago

@Ezriilc well it doesn't build when they are floats, so I've definitely contributed to the problem.

Now that I'm able to build locally I'll make sure it's tested before I push up any more PRs :-)

Ezriilc commented 5 years ago

In my random, uninformed panic to fix the build, I seem to have already reverted this.

craidler commented 5 years ago

No panic, just one step after the other ;-)

Ezriilc commented 5 years ago

I sure do appreciate everyone's help. I simply could NOT do this without you.