search

Ezwen / bandcamp-collection-downloader

A command-line tool to automatically download all releases purchased with a Bandcamp account. The official page of the project is https://framagit.org/Ezwen/bandcamp-collection-downloader, while here this is just a mirror hosted on Github.
GNU Affero General Public License v3.0
244 stars 23 forks source link

Bug: attempt to download item even if it is considered a pre-order item #23

Open jdheyburn opened 3 years ago

jdheyburn commented 3 years ago

Okay so I'm not sure this is a bug, nor am I entirely sure it's a feature request.

Bandcamp allows artists to update releases over time. One particular release has been "enhanced" with additional tracks and has a change of name.

https://zakedrone.bandcamp.com/album/carolina-coppice-movements

This used to be called "Coppice Movements" and was available at the below URL, which actually now redirects to the URL above.

https://zakedrone.bandcamp.com/album/coppice-movements

It's since been updated to include another album "Carolina", but the release ID remains the same.

It has a release date of April 23 2021 (I'm writing this on April 10 2021) and so the downloader does not attempt to download it because it is considered a pre-order item. I am actually able to download the "new enhanced" version via the browser - indicating that the file is there.

Note I think this will require an additional enhancement to download updated albums, even if the cache says the old version was already downloaded - I have raised this as #24.

Thanks!

Ezwen commented 2 years ago

Hi there. Interesting corner case!

What I am not sure to get in the case you describe is that, even with a release date in the future (?) it was possible for you to download the release in its current form using the web interface. Am I understanding this right?

This would mean we need a better heuristic to detect "undownloadable" pre-releases. Probably there is some metadata available in the API to achieve this, but some investigation would be required.

jdheyburn commented 2 years ago

I apologise for not capturing more info at the time since I cannot replicate it anymore, perhaps when my library expands more in future it could be reproduced. Feel free to close it out at this point since it's not really actionable.

Ezwen commented 2 years ago

No worries, it's my fault for answering very late. We can keep it open in case, and if I have the opportunity to investigate I'll try to gather more info. Thanks!