search

Ezwen / bandcamp-collection-downloader

A command-line tool to automatically download all releases purchased with a Bandcamp account. The official page of the project is https://framagit.org/Ezwen/bandcamp-collection-downloader, while here this is just a mirror hosted on Github.
GNU Affero General Public License v3.0
245 stars 23 forks source link

Bandamp rate limiting causing files not to download #30

Open demize opened 2 years ago

demize commented 2 years ago

Bandcamp appears to have implemented some sort of aggressive rate limiting on their end that causes problems with bandcamp-collection-downloader; after a few releases are downloaded, Bandcamp starts returning 429 Too Many Requests instead of files, and the downloads fail.

The most effective way of combating this may be to implement exponential backoff on 429 errors such that all albums end up downloaded without making Bandcamp too angry; as it is, large portions of your library fail to download because the current retry method is too quick.

roxaloxa commented 2 years ago

Any traction on this? Running into it now as well

Ezwen commented 2 years ago

Thanks for the report. Indeed that's an issue. I haven't encountered it yet, but I should run some tests to see if I can reproduce it.

If anyone wants to try a fix, PRs are of course welcome − I don't know when I will have time to make the fix :/

roxaloxa commented 2 years ago

@Ezwen I always hit it somewhere around 20 downloads, everything after failed with code 429. I just kept running the script until my entire collection synced, and now I doubt I'll ever hit it again as I likely won't buy more than 20 albums at once haha. So it's weird in that it shouldn't happen often... but likely guaranteed to happen immediately on first time use?

FabioLolix commented 2 years ago

Hello, I have installed the program earlier today, seeing this issue I have set the number of jobs to 1, I'm at download N° 118 without problems so far