search

Ezzz-dev / Nostalrius

Nostalrius is a 7.7 Tibia Clone Project based on The Forgotten Server 1.2 and CipSoft files.
99 stars 67 forks source link

BUG Crash #64

Closed htc16 closed 2 years ago

htc16 commented 3 years ago

We have a bug on this base that causes it to crash. The same was fixed in TFS, however the commit is different from the applications that can be applied here in the base.

Here's a reported bug: https://otland.net/threads/gdb-error-crash.274852/#post-2646765

Commitment Follows FIX: https://github.com/otland/forgottenserver/commit/b18cf9ff8da9b83b1ca3e99ea5d4b83496d59227

tarantonio commented 3 years ago

How can I reproduce the bug? Do you use the repo as it is or you made modifications? My working server don't have that crash at the moment.

htc16 commented 3 years ago

How can I reproduce the bug? Do you use the repo as it is or you made modifications? My working server don't have that crash at the moment.

my server is uniquely this one, without modification! my server started to go down after months online.. apparently it has to do with some timer. it seems to me that the bug has been with the TFS fix I posted above: https://github.com/otland/forgottenserver/commit/b18cf9ff8da9b83b1ca3e99ea5d4b83496d59227 my server crash anytime, no specific time.

tysonstrange commented 3 years ago

Are you still having this crash? I've not seen it occur.

tysonstrange commented 3 years ago

I dont think this crash or this fix posted are related.

The fix posted relates to a bug that was introducted when moving from the Scheduler to boost::asio

The fix was changing the code for the boost::asio method, this scheduler is using a lock and shouldn't be related to this.