search

Ezzz-dev / OTHire

OpenTibia Server for Tibia 7.72
GNU General Public License v3.0
86 stars 76 forks source link

Party shared exp multiple numbers showing #97

Closed peonso closed 8 years ago

peonso commented 8 years ago

The way it's calculated now after a monster die each party member wil get a white experience number above head for each party member that deals damage. Newer Tibia client/Otclient consolidate numbers and don't have to deal with it (I'm not sure though).

peonso commented 8 years ago

Also check if https://github.com/TwistedScorpio/OTHire/blob/322095b12dbbfe6644dff6a615f43d7dcd27e2ab/source/party.cpp#L404 shouldn't actually be 

double xpgained = experience * (1 + member_factor / 100.) / (memberList.size() + 1);

It was changed, no idea why. https://github.com/TwistedScorpio/OTHire/commit/99ebed606153d195f3bc0cc125b35e40fdd2aec4#diff-92eb1a1007662af9f579fccf95e610e4L382

peonso commented 8 years ago

It's an issue on forgottenserver also? https://github.com/otland/forgottenserver/issues/629#issuecomment-37584959 I'm not sure.

diegorodriguesvieira commented 8 years ago

https://github.com/opentibia/server/blob/master/src/party.cpp#L406

peonso commented 8 years ago

Since there is a ceil and exp_stages is applied later, there are some strangers bonus, specially at lower exp monsters (20% bonus at a cave rat at 30x stage multiplier), but it's working as intended, and fixing it would require to be applying exp_stages before any round is done. So if ever it's considered an issue, it's an issue with exp_stages, because it's applied after the rounding.

I just confirmed the original bug of multiple experience messages was present in TFS 1.x also. https://github.com/otland/forgottenserver/issues/629#issuecomment-37584959 https://github.com/otland/forgottenserver/issues/1432 https://github.com/otland/forgottenserver/pull/1344#issuecomment-126942861

The pull request that fixed the issue. https://github.com/otland/forgottenserver/pull/1579