Closed yochananmarqos closed 2 years ago
https://github.com/F-i-f/tweaks-system-menu/blob/master/meson-gse/meson-scripts/install-po
@F-i-f
I don't understand the purpose of this script. It seems to be perfectly identical to not using the script, and instead just leaving install: true
as the default.
Whatever the purpose of this script is, it should not be using meson --internal ...
commands as those are not public API and the name --internal
is specifically intended to warn people against using it, because it is after all "internal" implementation details.
I would prefer to avoid renaming that to meson --do-not-use-this-in-scripts ...
, but if you think that that would be clearer... ;)
Current versions of meson refactored this internal implementation detail from a script to generating build.ninja rules and installing the same way custom_target()
gets installed, i.e. it runs more predictably and efficiently and gets tracked by ninja uninstall
. The removal of the python functions in mesonbuild/scripts/gettext.py is not considered a breaking change.
It's not clear to me why you don't want to use the builtin installation method?
The builtin install for po files was broken at some point in the past, which is why a manual install was performed instead. I'll correct this.
Huh, which version was broken? And how was it broken?
Maybe that's something I fixed while reworking its internals. :D
meson before 0.50.0 couldn't override the destination directory of the po files, and was always installing into the system po directory.
That didn't work for building Gnome Shell extensions that need to install po files in alternate locations.
The meson build scripts used to only require meson 0.44.0, and was invoking meson --internal
directly to work around the issue. That broke in meson 0.60.0.
I've fixed the issue by requiring meson 0.50.0 (instead of 0.44.0) and relying upon the builtin po installer.
Ah, indeed... Glad to see everything works out, anyway.
If it hadn't then we could always add new options to handle interesting use cases ;)
I'm guessing something changed with the release of Meson 0.6.0?
meson-log.txt
: