F0rce / ace

Ace Editor for Vaadin 14 & 23
MIT License
27 stars 13 forks source link

Search doesn't work #17

Closed lipisak closed 3 years ago

lipisak commented 3 years ago

Hi @F0rce, We have upgraded to the new version 1.2.3 with Vaadin 14.5.6. Everything works but search. When I press CMD+F javascript error is thrown that

GET http://localhost:8091/ace-builds/src-min-noconflict/ext-searchbox.js net::ERR_ABORTED 404

Could it be related with the last change (make baseUrl relative?). Themes and modes works good and from what I see they are "loaded" from compiled bundle, but this extension is loaded directly not from bundle...

Thx JS

F0rce commented 3 years ago

Hi @lipisak,

this is pretty sure my bad 100 %. Due to the big size the src-min-noconfict & the src-noconflict directorys had, I removed the src-noconflict (which is not needed to be in the frontend directory) and I cleared most of the not needed files in src-min-noconflict. Pretty sure I accidentely deleted the ext-searchbox.js file. I will check it out surely and will build a hotfix as fast as possible.

Sorry for that inconvenience

Already on it :)

David

F0rce commented 3 years ago

Already fixed it and building the new version. Should be availible as version 1.2.4 on the directory in aprox. 25-30 minutes

F0rce commented 3 years ago

and obviously sorry for the inconvenience

lipisak commented 3 years ago

It's ok... thank you for quick response...

F0rce commented 3 years ago

https://vaadin.com/directory/component/ace/1.2.4 --> could take some minutes to be availible via maven