search

F0rce / ace

Ace Editor for Vaadin 14 & 23
MIT License
27 stars 13 forks source link

Add a way to set custom completition and keep 'keyWordCompleter' and 'snippetCompleter' #2

Closed danijelz closed 3 years ago

danijelz commented 3 years ago

Currently the use of custom auto completion removes the 'keyWordCompleter' and 'snippetCompleter' from completers array and only 'staticWordCompleter' is used (lit-ace.js). Would it be possible to add another parameter to 'setCustomAutoCompletion' methods by which users can decide to keep the 'keyWordCompleter' and 'snippetCompleter' or maybe add methods like 'addCustomAutoCompletion' which would keep the 'keyWordCompleter' and 'snippetCompleter' and add the custom one?

F0rce commented 3 years ago

Hello Danijelz,

my solution for this feature request would be:

Would that fit your request?

David

danijelz commented 3 years ago

That would be perfect. Thanks for fast reply.

F0rce commented 3 years ago

this commit has been reverted!

i'm still working on those changes

F0rce commented 3 years ago

I think I will release the customAutoCompletion changes later today, and investigate #3 later on.

F0rce commented 3 years ago

one short question @danijelz

what version are you using? latest (1.1.0) or 1.0.1 ? just curious

danijelz commented 3 years ago

I'm using 1.0.1 but i'll switch to 1.1.0 right now and let you know how it works...

EDIT:

Looks like it works the same.

F0rce commented 3 years ago

the customAutoCompletion Changes will be implemented in v1.1.1 (if you mean that).

danijelz commented 3 years ago

I tested and closed issue. Works perfectly.