F0rce / ace

Ace Editor for Vaadin 14 & 23
MIT License
27 stars 13 forks source link

Support for Vaadin 24 #40

Open vaithu opened 1 year ago

vaithu commented 1 year ago

Hi

I was told this is using polymer 2 and so it cannot be used in Vaadin 24. If so, when you find time, could you please let this also work for Vaadin 24. My application is heavily dependent on this wonderful editor and I can move that application to V24 only if this editor works in V24.

F0rce commented 1 year ago

Hello @vaithu

There is already a version of my ace editor that works in Vaadin 23 / Vaadin 24. Every version on the Vaadin Directory that starts with 3.x should be compatible.

Could you please give it a try and see if it works for you ?

3.x is also more maintained and has some additional features, I did not find the time for to backport to 2.x (Vaadin 14)

gjevardat commented 1 year ago

Hello not sure why but it seems I have a regression using Vaadin 24 and 3.4.2 ( using quarkus) Uncaught TypeError: $0.setValue is not a function (http://localhost:8080/VAADIN/build/FlowClient-d5d5e377.js:1:7757)

Not sure if can help here is the small code

AceEditor ace = new AceEditor();
        ace.setMode(AceMode.xml);
        ace.setAutoComplete(false);

        // Button click listeners can be defined as lambda expressions
        Button button = new Button("Say hello", e -> {
           ace.setValue("Hello");
        });
Adr3nl commented 1 year ago

Im having the exact same issue. I believe I've tried it before with Vaadin 23 and it was working just fine.

F0rce commented 1 year ago

Sorry for the late reply @gjevardat @Adr3nl - are you using Spring? If so, you would need to include de/f0rce with vaadin.whitelisted-properties in application.properties (ref: Vaadin Docs).

I wouldn't know what else could be causing incompatibility with Vaadin 24. Please make sure to be on the latest 3.x Version.

gjevardat commented 1 year ago

Ok I confirm it works well in a base spring boot vaadin 24 project ! But Fyi It is not working in Quarkus vaadin versions

Querela commented 9 months ago

Thanks, for me it helped to set vaadin.allowed-packages = com.vaadin,org.vaadin,de/f0rce with Spring and Vaadin 24. First it worked without issues (and I was not aware of this setting) but then I had to rename packages and afterwards it didn't want to work anymore. I'm unsure why it worked before, maybe because I used the Jetty-Dev Setup before I switched to SpringBoot and it used a stale work environment?