search

F0rce / ace

Ace Editor for Vaadin 14 & 23
MIT License
27 stars 13 forks source link

Value is not returned back to server #9

Closed lipisak closed 3 years ago

lipisak commented 3 years ago

Hi @F0rce, I updated to the new 1.2.0 version. UI built up correctly and the component showed up correctly. But I don't get the value from client back to server (doesn't matter if it is connected to binder or not).

Could you please check it up?

Thank you J

F0rce commented 3 years ago

Hello @lipisak,

the value is not binded. It is synced when the editor is blurred (if you didnt knew already).

I'm currently working on some new methods for the Editor so I will surely try it now. But as far as I can see in the web-console the event is sent normally from the frontend and the listeners seem to work.

Will investigate it shortly and update you.

David

F0rce commented 3 years ago

You were right, when implementing the changes in #3 I removed a line because I thought I didnt need it. But as far as I can see, it doenst update the value of the editor anymore... What a dumb mistake of mine.

v1.2.0 will not be availible anymore due to this error.

Thanks for showing me, working on a hotfix

F0rce commented 3 years ago

I fixed it locally and will publish a hotfix / replace the current version with the fix later today. sorry for the inconvenience...

lipisak commented 3 years ago

Wow that was quick...thank you...This time I will test it locally, as we always discover this in production. I know - not a good approach.

F0rce commented 3 years ago

fixed everything https://vaadin.com/directory/component/ace/1.2.1