search

F1ash / qt-virt-manager

Qt Virtual machines manager
http://f1ash.github.io/qt-virt-manager
GNU General Public License v2.0
241 stars 72 forks source link

KDE icons are not used #19

Open peterhoeg opened 7 years ago

peterhoeg commented 7 years ago

When running the qt5 version under KDE, the program uses its own application icons instead of the chosen KDE icon theme.

Tried on the latest 0.42.67 as well as 0.39.60.

F1ash commented 7 years ago

Application uses only own icon theme. it not designed for using another icon themes, because it contains very specific icon names. Using different icon themes will be broke the common style of icon set. Moreover, the application is cross-platform, so it will be difficult to achieve a single style. At the moment, using own set of icons is a working solution.

peterhoeg commented 7 years ago

Hi @F1ash, thanks for all your work on qt-virt-manager.

Would you consider adding support for using the icons from the theme? You could even expose a user toggle that decided if the theme should be preferred.

Apart from your connection icon (the one that looks like a swan head, which I admittedly don't get), all the other icons are provided by most of the icon themes on Linux. So the change would come down to:

a) rename the existing icons to follow the freedesktop specification, and b) use QIcon::fromTheme() to load the icons, which will automatically fall back to your application provided icons in case they don't exist.

F1ash commented 7 years ago

I know all it... But OSX and Win not uses freedesktop standards. It's easier if you wrote a list of icons that need to be replaced with more understandable ones (new names, for example, from oxigen icons of the theme or same).

peterhoeg commented 7 years ago

Just FYI, I haven't forgotten about this but I simply haven't had the time yet.