fix #274: keep track of done processes

F1bonacc1 / process-compose

Process Compose is a simple and flexible scheduler and orchestrator to manage non-containerized applications.

https://f1bonacc1.github.io/process-compose/

Apache License 2.0

1.33k stars 52 forks source link

fix #274: keep track of done processes #276

Closed secobarbital closed 1 week ago

secobarbital commented 2 weeks ago

Keep track of done processes in case we have to start a process that depends on another process that has already exited.

PS I would love to add a test but I don't know how to run tests in this project!

Closes #274

secobarbital commented 2 weeks ago

The change I made is the least intrusive one to fix this issue, but I wonder if it is better to maintain just a single list of processes which includes all processes in every stage of their lifecycle (pending, started, skipped, completed). That would probably require changes in the logic of some of the functions that access this list.

F1bonacc1 commented 1 week ago

PS I would love to add a test but I don't know how to run tests in this project!

I use make so I usually do make testrace which is equivalent to go test -race ./src/...

sonarcloud[bot] commented 1 week ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

secobarbital commented 1 week ago

@F1bonacc1 I noticed this was mentioned in the v1.40.0 Release Notes but the code was not merged 😅

F1bonacc1 commented 1 week ago

@secobarbital you are right, not sure what happened there... 🙃 Merged and released as v1.40.1