search

F32Organization / Faithful32-1.7.10

1.7.10 repository for Faithful 32 Modded Edition.
http://f32.me/
105 stars 55 forks source link

Buildcraft 7+ texture #331

Open Unrepentant-Atheist opened 9 years ago

Unrepentant-Atheist commented 9 years ago

Textures for Buildcraft Version 7+ need to be redistributed as Buildcraft is made modular. The names are the same, just not 1 folder anymore.

Evolution0 commented 9 years ago

This is problematic as inside the jars the textures are not in an assets folder, they are just loose files mixed in with the class files which would mean that all BC7 textures would need to be present in the root of the repo.

Now they can be put in a folder for the sake of keeping things neat and later moved by the script during packaging.

Might want to wait for a second opinion on this though the modifications are super simple.

Unless I'm missing something entirely and the textures can still somehow be found if put in an assets/buildcraft directory. As far as I know resource packs mimic the filestructure of the mods.

Unrepentant-Atheist commented 9 years ago

What do ya mean problematic? All ya gotta do is create folders and redistribute the textures y'all currently got in buildcraft. The new folder structure is this one: http://i.imgur.com/ebjOGTr.png

Of course if you do that and delete the BC 6 folder structure, folks with BC 6 won't see the Faithful textures.

To solve that you can leave buildcraft as it it now, and copy/paste the textures into the new folders. Would then work with BC6 and BC7. Sure it would mean double the amount of textures, but you can't have it both ways.

Evolution0 commented 9 years ago

I know that, I couldn't figure out the folder structure though as when you pop open the jar files there are no folders inside. I had to go over to the buildcraft repo and take a peek at the source just to figure it out.

So by problematic I was under the assumption that they weren't even using an assets directory which would have made a mess.

Nevertheless, getting it done now. Though from the looks of it a lot can't be re-used.

Edit: Done, just need to wait for my other PR to go through as I don't feel like branching and stacking PRs is ugly.

What a mess this is, almost all BC textures need to be redone for BC7, at first glance a lot look the same but this isn't really the case and the differences would be noticeable in-game if I simply copied them.

Can't say I'm mad though, I'm of the opinion that they look better than the old ones so it will be worth it in the end.

Unrepentant-Atheist commented 9 years ago

You do know, you can rename any .jar into .zip and open it up?

StefanTT commented 9 years ago

Just as a quick side node: I would prefer to not drop BC6 support yet, as most mod packs still use BC6.

Evolution0 commented 9 years ago

I've already mentioned twice that I have opened them up and you don't need to rename them to do it.

Here a picture would give a better idea of what I'm saying: Buildcraft Robotics There are no folders but there are loose class and image files.

That is irrelevant now though, I've created the modular folder structure based on the BC repo and moved over what was salvageable, I've left the existing BC folder untouched to maintain BC6 support.

If a user adds the BC7 (non-modular) jar does it use the main BC folder to the separate folders?

Basically what I'm asking is are the modular texture folders only used when using the modular jar files?

StefanTT commented 9 years ago

Urks that looks very ugly (having the images in the root folder). We should file a request at buildcraft's and ask them to do proper folders.

StefanTT commented 9 years ago

Ok I had a look at the JARs, just to be sure. Downloaded both the all-in-one and some modular JARs of bc 7.0.8 from http://mod-buildcraft.com/pages/download.html

For me they are properly packaged with assets/*/textures folders.

Evolution0 commented 9 years ago

Then its most likely that peazip is collapsing everything in flat mode and showing me only the files, disabling flat mode hides any directories and shows me just the license.

No big deal, I can check the full name on the right it seems which has the full path in it.

Edit: Check my PR, just to reiterate I have not touched BC6 support so that should be perfectly fine.

GamerM commented 9 years ago

As of right now i'm going to work on the redistribution of the files. As of buildcraft 7.0.13 all texture seen before in the Buildcraft folder assets/buildcraft are completely remove. Does that mean everything inside the folder need to be cut and pasted to the right folder. I'm seeing double copies tbh. Also is the TODO folder updated to the recommended version of the mod?