search

F43nd1r / zachtronics-leaderboard-bot

Apache License 2.0
3 stars 8 forks source link

Add button to download puzzle file #296

Open BredBeanQueen opened 1 month ago

BredBeanQueen commented 1 month ago

Add a button in the top right corner of a puzzle view allowing for user to download the .puzzle file directly instead of going through steam.

Currently needs line 116 of web/src/views/om/puzzles/PuzzleView.tsx to be updated to link to a download of the puzzle, instead of the steam page.

12345ieee commented 1 month ago

I will get to this, but not this weekend.

12345ieee commented 1 day ago

Please don't keep the branch up to date manually by recursive merging.

Either rebase it cleanly every once in a while or leave it as is.

I've force pushed to your branch such a rebase while I test it.

12345ieee commented 1 day ago

Compile fails with:

[eslint] src/views/om/puzzles/PuzzleView.tsx Line 105:22: 'Download_Buttons' is not defined react/jsx-no-undef

I'm 100% lost in this.

BredBeanQueen commented 1 day ago

Please don't keep the branch up to date manually by recursive merging.

Either rebase it cleanly every once in a while or leave it as is.

I've force pushed to your branch such a rebase while I test it.

Sorry about this, I was unaware of the correct way to handle this using github, will rebase properly in the future if needed.

Compile fails with:

[eslint] src/views/om/puzzles/PuzzleView.tsx Line 105:22: 'Download_Buttons' is not defined react/jsx-no-undef

I'm 100% lost in this.

That is my own fault, didn't realise the syntax of a fragment required the element tag to be specifically <></> when changing it and didn't check that change with an ide. The point of the fragment is to allow having 2 buttons there since that is 2 elements when typescript only allows 1.