Docker file enhancements

F45FW / generator-fwsp-hydra

Yeoman generator for Hydra services

MIT License

8 stars 5 forks source link

Docker file enhancements #12

Closed cjus closed 7 years ago

cjus commented 7 years ago

In the generated Docker file:

Thinking that the maintainer name/email should be changed to: Your name name@yourdomain.com
We should use mount points for the config folder... that would allow for updating services without having to commit changes to a container. See: https://docs.docker.com/engine/reference/builder/#volume

cjus commented 7 years ago

Perhaps there should be a generator props for organization and user name an email address. Then the docker namespace and maintainer can be properly set in the resulting scripts/docker.js file.

cjus commented 7 years ago

The generated Dockerfile should use RUN npm install --production to ensure that devDependencies don't make it into the created container.

emadum commented 7 years ago

We should use mount points for the config folder... that would allow for updating services without having to commit changes to a container. See: https://docs.docker.com/engine/reference/builder/#volume

I can see that being useful, but I'm not sure it makes sense as a default. What would the volume name be?