search

F45FW / generator-fwsp-hydra

Yeoman generator for Hydra services
MIT License
8 stars 5 forks source link

JSON parsing error in after this commit #2

Closed cjus closed 7 years ago

cjus commented 7 years ago

Commit: https://github.com/flywheelsports/generator-fwsp-hydra/commit/fe8dc11963450a8fe847f56be152e867f3e93daa

┗━➤ yo fwsp-hydra
{ 'fwsp-hydra-express': '0.11.9',
  'fwsp-server-response': '2.2.3',
  'fwsp-hydra': '0.11.5',
  'fwsp-jwt-auth': '0.0.7',
  'fwsp-logger': '0.0.5',
  'fwsp-jsutils': '1.0.8',
  'fwsp-config': '1.0.4' }
? Name of the service (`-service` will be appended automatically) hello
? Host the service runs on? 
? Port the service runs on? 0
? What does this service do? 
? Does this service need auth? No
? Is this a hydra-express service? Yes
? Set up a view engine? No
? Set up logging? No
? Enable CORS on serverResponses? No
? Run npm install? No
   create hello-service/specs/test.js
   create hello-service/specs/helpers/chai.js
   create hello-service/scripts/docker.js
   create hello-service/.editorconfig
   create hello-service/.eslintrc
   create hello-service/.gitattributes
   create hello-service/.nvmrc
   create hello-service/.gitignore
   create hello-service/package.json
   create hello-service/README.md
   create hello-service/hello-service.js
   create hello-service/config/sample-config.json
   create hello-service/config/config.json
   create hello-service/routes/hello-v1-routes.js

Done!
'cd hello-service' then 'npm install' and 'npm start'

┏━➤ [09:57:41]: ~/dev
┗━➤ cd hello-service/

┏━➤ [09:57:47]: ~/dev/hello-service
┗━➤ npm install
npm ERR! Darwin 15.6.0
npm ERR! argv "/Users/cjustiniano/.nvm/versions/node/v6.9.2/bin/node" "/Users/cjustiniano/.nvm/versions/node/v6.9.2/bin/npm" "install"
npm ERR! node v6.9.2
npm ERR! npm  v3.10.9
npm ERR! file /Users/cjustiniano/dev/hello-service/package.json
npm ERR! code EJSONPARSE

npm ERR! Failed to parse json
npm ERR! Unexpected token '4' at 15:24
npm ERR!     "fwsp-config": 1.0.4
npm ERR!                        ^
npm ERR! File: /Users/cjustiniano/dev/hello-service/package.json
npm ERR! Failed to parse package.json data.
npm ERR! package.json must be actual JSON, not just JavaScript.
npm ERR! 
npm ERR! This is not a bug in npm.
npm ERR! Tell the package author to fix their package.json file. JSON.parse

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/cjustiniano/dev/hello-service/npm-debug.log

┏━➤ [09:57:49]: ~/dev/hello-service
┗━➤
cjus commented 7 years ago

It's just that the version numbers require quotes below and also commas are missing:

  "dependencies": {
    "fwsp-config": 1.0.4
    "fwsp-hydra-express": 0.11.9
    "fwsp-server-response": 2.2.3
  },