F45FW / generator-fwsp-hydra

Yeoman generator for Hydra services
MIT License
8 stars 5 forks source link

Needs pino-elasticsearch dependency when "Set up logging" is Yes #21

Closed copongcopong closed 7 years ago

cjus commented 7 years ago

@copongcopong Thanks for your feedback. We'll get back to you shortly.

emadum commented 7 years ago

Sorry about the delay in getting to this! pino-elasticsearch needs to be installed globally which is why I didn't just add it to the dependencies. I'm thinking perhaps adding a postinstall script to the generated package.json which just does npm install --global pino-elasticsearch is the best move.

@cjus thoughts?

cjus commented 7 years ago

@emadum updating the documentation for the generator would let users know that if they enable logging then the above install is necessary.

emadum commented 7 years ago

child_process.fork is now used instead of cross-spawn, meaning npm install --global pino-elasticsearch is no longer needed.