F483 / bikesurf.org

MIT License
8 stars 5 forks source link

New couchsurf profile url. #59

Open F483 opened 9 years ago

F483 commented 9 years ago

They changed the link format (old still works). Update the site to accept the now format.

dcarral commented 9 years ago

Here is a "quick & dirty" fix to this issue, so newer users can enjoy the platform: https://gist.github.com/dcarral/2bdac43363984ddce18f

A single regex would be enough to capture them all though. I wanted to integrate a unit test framework (unittest?) so I could properly introduce these changes, but as commented by e-mail, I was trapped by a dependency hell when preparing the development environment.

Looking forward to that migration to newer versions of Python/Django, hopefully contributing to the project would be less problematic then ;)

dcarral commented 9 years ago

Fwiw, patch -p1 < bugfix_59.patch would be good enough to apply it, as suggested in http://stackoverflow.com/questions/4610744/can-i-get-a-patch-compatible-output-from-git-diff

If you're wondering why I don't send the pull request directly: I don't feel comfortable contributing code without a solid test suite, specially in a project with an unfamiliar technology and whose environment I'm not able to set-up ;)

deivid-rodriguez commented 6 years ago

Closed by #78!