F4IF / ctree-demo

Collaboration Tree - A community discussion platform built for maximum insight with minimum oversight.
http://demo.ctree.org
Other
37 stars 22 forks source link

Landing Page Toolbar Selection Issue - CTree and Participate #104

Closed begunfx closed 5 years ago

begunfx commented 5 years ago

When selecting any of the following toolbar options: Overview, Feedback, or Features (which all scroll the screen) then select Participate. The toolbar will switch the active selection to cTree. If we are already on cTree or Participate and select either one the toolbar selection executes as expected.

begunfx commented 5 years ago

This should be fixed now. We were missing a cTree section, but had it in the tab list, so that seems to be why when we selected Participate from another tab it would get a bit confused. (Fixed in develop-landing-page_begunfx branch).

CSchmitz81 commented 5 years ago

Is there a change required for this? It sounds like it since you talked about a fix. If so, we should reopen this until the fix has been merged in.

It's best to have separate pull requests for each issue, but if you rolled changes for multiple issues into one branch just be sure to mention each issue in the pull request.

begunfx commented 5 years ago

It should be fixed in my branch. Okay, no worries, I'll re-open this until we merge the branches.