search

F4IF / ctree-demo

Collaboration Tree - A community discussion platform built for maximum insight with minimum oversight.
http://demo.ctree.org
Other
37 stars 21 forks source link

convert project to polymer3 #105

Closed dimaostrov closed 5 years ago

dimaostrov commented 5 years ago

Update the repo to use npm and polymer3 components

CSchmitz81 commented 5 years ago

Thanks for taking the time to do this @dimaostrov. Unfortunately it's a big change and a low priority one, so the extensive review and testing need to merge this in probably won't happen for a while. The top priority is getting the MVP done, followed by the landing page. After that updating to Polymer 3 might be a higher priority, as long as it's just as easy to work with as Polymer 2.

I'm not sure where that leaves this PR, since there will probably be a lot more code which needs to be converted by that point. Maybe we can run the auto-converter again on the project, then merge those changes into this branch and work through any conflicts. Can you give any insight into the specific changes you made beyond what the auto converter did? You might even want to comment on your own code in the PR so we can see it inline.

Is there some reason you chose to work on this rather than one of the open issues? In other words, was there something you were trying to solve other than just updating to the latest and greatest. If there's a good reason to prioritize this it might provide motivation to get it reviewed and merged sooner. I should reiterate what I always say, that people are free to work on whatever they want with the project, but we can only guarantee that issues for the prioritized projects (currently MVP and landing page) will be reviewed and merged as a priority. You could make some great additions we didn't ask for but we end up wanting to merge once we see them, but you're taking a chance when you do that. If you're going to be disappointed to not see your contribution prioritized for quick review it may be safer to work off the prioritized projects.

Thanks!

dimaostrov commented 5 years ago

There wasn't any additional code written, only the auto convert, maybe it might be a good a change to update at this point in time as Bower has been deprecated, and I think a lot of people can benefit from using Polymer 3 as it has some similarities to Angular (which is high demand), and we can also use Angular components inside of this code.

CSchmitz81 commented 5 years ago

I investigated this awhile ago and there were still plenty of things which needed to be manually updated to work correctly (there's a list on polymer-project.org). With so many changes we need careful review to ensure it's correct, so it's just not something we can afford to spend time on now. The Bower and Angular points are good to consider, although I'm not sure if we want to use Angular in the project at this point (it probably depends on the benefit). Since this was just the auto converter and no manual work went into it I'm going to close it for now and we can open a new one when we're ready. I think we may already have an open issue for upgrading, but if we don't feel free to open one. It would also be good to add your points about Bower and Angular to the comments.