Develop landing page footer upd

nhefner12 commented 5 years ago

Modified the landing page footer to resemble Alex's wireframe on invision

nhefner12 commented 5 years ago

need to add mobile support

nhefner12 commented 5 years ago

added mobile support

CSchmitz81 commented 5 years ago

For #120

CSchmitz81 commented 5 years ago

OK, just tested this and it needs a bit of cleanup work. With my background in front end mobile development I get pretty picky about matching comps, and it's an important skill to develop. I recommend opening landing page in a window and the comp in a new tab of the same window, then size the window to the width of the comp and compare the tabs. Here's what I spotted:

the footer isn't as tall as the comp
the "project of" text needs more margin on the left side (I think it's the same padding on the left/right sides of the window)
the spacing between the sharing icons and the "project of" text needs to be increased slightly
the space between the sharing icons needs to be increased slightly
all text is italicized but shouldn't be
the copyright text should be larger
for mobile, the text has too much padding (it's much less for the mobile comp)
for mobile, the text appears to be larger than the comp

On the issue of the copyright text, I actually agree with you using copyright instead of @ (it makes a lot more sense), so go ahead and keep that difference.

CSchmitz81 commented 5 years ago

Is this something you plan to work on during the hackathon this Saturday?

nhefner12 commented 5 years ago

Yes, this was something I was planning on doing on or before Saturday.

On Tue, Oct 1, 2019 at 8:26 PM Chris Schmitz notifications@github.com wrote:

Is this something you plan to work on during the hackathon this Saturday?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/F4IF/ctree-demo/pull/124?email_source=notifications&email_token=AK6HMJMNQXNIZMI54QVHOQDQMQIH7A5CNFSM4IVBKLOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEADNP5Y#issuecomment-537319415, or mute the thread https://github.com/notifications/unsubscribe-auth/AK6HMJJ2JKZXDE3IIDCGOX3QMQIH7ANCNFSM4IVBKLOA .

nhefner12 commented 5 years ago

Fixed up some of the comp dissimilarities. Please review and let me know what you think.

F4IF / ctree-demo

Develop landing page footer upd #124