I didn't see any specific issues with this, but I'm a little concerned about how it's likely to conflict with changes to master. It looks like the last commit from master to be merged back into the mvp branch was bf1e957 in Feb 2019, and there have been 5 commits to master since then (including adding the package files via PR #151) that didn't get merged into mvp. It may be worth checking if the latest changes from master can be merged back into mvp and regenerating the package files to see if there are any differences specifically needed for the mvp branch. If not, this can just be closed, since the new files would have already been merged into mvp from master.
I didn't see any specific issues with this, but I'm a little concerned about how it's likely to conflict with changes to
master
. It looks like the last commit frommaster
to be merged back into themvp
branch was bf1e957 in Feb 2019, and there have been 5 commits tomaster
since then (including adding the package files via PR #151) that didn't get merged intomvp
. It may be worth checking if the latest changes frommaster
can be merged back intomvp
and regenerating the package files to see if there are any differences specifically needed for themvp
branch. If not, this can just be closed, since the new files would have already been merged intomvp
frommaster
.