search

F5Networks / charts

Helm charts for using F5 products and services in Kubernetes and OpenShift environments.
Apache License 2.0
28 stars 34 forks source link

Fix #17: Make RBAC resources unique and optional #18

Open rendhalver opened 6 years ago

rendhalver commented 6 years ago

Problem: With the current Chart RBAC resource names are hard coded and not optional so it's impossible to deploy more than one instance in a namespace

Solution: This uses the helper f5-bigip-ctlr.fullname as the name of each resource to it's unique. It also add variables to make the RBAc resources optional. You can also set the name of the service account to use so you can use it across all deploys.

Testing (optional if not described in Solution section): Description of tests that were run to exercise the solutions (unit tests, system tests, etc)

rendhalver commented 6 years ago

Any progress on this?

recursivelycurious commented 6 years ago

@rendhalver - Thanks for the contribution. Under review.

ghost commented 5 years ago

@rendhalver : Please update the patch with requested changes

rendhalver commented 5 years ago

@rendhalver : Please update the patch with requested changes

I answered the question. No one responded.

recursivelycurious commented 5 years ago

@trinaths -- please take another look at this MR.