Fixes for from PR #18 + credentials directory

F5Networks / charts

Helm charts for using F5 products and services in Kubernetes and OpenShift environments.

Apache License 2.0

28 stars 36 forks source link

Fixes for from PR #18 + credentials directory #23

Closed chen23 closed 4 years ago

chen23 commented 5 years ago

Includes https://github.com/F5Networks/charts/pull/18

Also updates “stable” template

Adds “credentials directory” for secrets (new default)

mdditt2000 commented 5 years ago

@kavitha-f5 @f5tsomanchi dev can you please review and approve @chen23 commits. TY

ghost commented 5 years ago

@chen23 @rendhalver - Fixes from PR#18, require CLA to be signed. Please find the CLA document at https://clouddocs.f5.com/containers/v2/cla_landing.html. Please submit/email a signed copy of the same to ContainerConnector_CLA@f5.com to consider the fix. Please include your github handle in the CLA email.

ghost commented 5 years ago

@chen23 - Can you please separate your fix for PR#18. @rendhalver fix requires CLA be signed and also need to attach that CLA in this conversation and I feel it may take time.

chen23 commented 5 years ago

per your request I have created a separate PR #25

trinaths commented 4 years ago

Closing this PR, since changes have been integrated.