search

F5Networks / charts

Helm charts for using F5 products and services in Kubernetes and OpenShift environments.
Apache License 2.0
28 stars 34 forks source link

image version is empty when using custom value #53

Closed marcinbojko closed 3 years ago

marcinbojko commented 3 years ago

When using custom image value, chart doesn't pick its name. According to doc this section should be sufficient:

image:
  # Use the tag to target a specific version of the Controller
  user: f5networks
  repo: k8s-bigip-ctlr
  pullPolicy: IfNotPresent
  version: someversion

When used this way, value for version is empty. You can workaround this by:

image:
  # Use the tag to target a specific version of the Controller
  user: f5networks
  repo: k8s-bigip-ctlr
  pullPolicy: IfNotPresent
version: someversion

which is illogical. This PR fixes deploy template to substitute from Values.image.version instead of Values.version

trinaths commented 3 years ago

@marcinbojko - Please submit completed and sign contributor agreement for contributing to this repo. Contributor license agreement - https://github.com/F5Networks/f5-ci-docs/blob/master/docs/_static/F5-contributor-license-agreement.pdf

marcinbojko commented 3 years ago

@trinaths No thank you. I am not going to give you my personal data.