Virtual server play not accepting string type for port

rajeshanne commented 6 years ago

ISSUE TYPE

Feature idea - Bug Report - Feature Idea - Documentation Report ##### COMPONENT NAME bigip_virtual_server ##### ANSIBLE VERSION

PYTHON VERSION

BIGIP VERSION

13.1 ``` ``` ##### LIBRARY VERSIONS

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

caphrim007 commented 6 years ago

@rajeshanne can you provide a reproduction? strings should be automatically converted to integers.

rajeshanne commented 6 years ago

Attached is the log...

Thanks, Rajesh

From: Tim Rupp notifications@github.com Sent: Tuesday, March 20, 2018 11:40 AM To: F5Networks/f5-ansible Cc: rajeshanne; Mention Subject: Re: [F5Networks/f5-ansible] Virtual server play not accepting string type for port (#675)

@rajeshannehttps://github.com/rajeshanne can you provide a reproduction? strings should be automatically converted to integers.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/F5Networks/f5-ansible/issues/675#issuecomment-374711640, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Abdj1tUMTwNvpG8GHEGyPboT2AmKzL7yks5tgU0sgaJpZM4Sya4Q.

ja702x@Ansible-Server:~$ ansible-playbook f5.yml --ask-vault-pass --tags virtual_v6 -vvv ansible-playbook 2.6.0 config file = /home/ja702x/ansible.cfg configured module search path = [u'/home/ja702x/library'] ansible python module location = /usr/local/lib/python2.7/dist-packages/ansible executable location = /usr/local/bin/ansible-playbook python version = 2.7.12 (default, Nov 19 2016, 06:48:10) [GCC 5.4.0 20160609] Using /home/ja702x/ansible.cfg as config file Vault password: Parsed /home/ja702x/hosts inventory source with ini plugin statically imported: /home/ja702x/roles/f5base/tasks/bigip_template/f5_template.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_provision/f5_afm_nominal.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_provision/f5_ltm_none.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_db/f5_sys_db.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_software/f5_sys_update_autocheck.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_profile/f5_profile_client_ssl.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_command/f5_profile_server_ssl.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_global/f5_sys_global.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_hostname/f5_hostname.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_sshd/f5_ssh.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_httpd/f5_httpd.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_snmp_trap/f5_snmp_trap.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_snmp/f5_snmp.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_snmp/f5_snmp_community.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_command/f5_mgmt_route.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_ntp/f5_ntp.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_vlan/f5_vlan.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_route/f5_route_remove.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_interface/f5_interface.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_route/f5_route_add.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_monitor/f5_monitor_jsa.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_pool/f5_pool_jsa.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_command/f5_dest_hsl.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_command/f5_dest_sys.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_command/f5_pub_sys.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_command/f5_log_profile.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_config/f5_config_save.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_command/f5_gtac.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_command/f5_net_timerpolicy.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_command/f5_net_servicepolicy.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_afm/f5_afm_portlist.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_afm/f5_afm_addresslist.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_afm/f5_afm_addresslist_multi.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_afm/f5_afm_rulelist_ue_v4.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_afm/f5_afm_rulelist_ue_v6.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_afm/f5_afm_policy.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_irule/f5_irule.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_virtual_server/f5_virt_hc_untrust.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_virtual_server/f5_virt_hc_trust.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_virtual_server/f5_virt_ue_v4.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_virtual_server/f5_virt_ue_v4_ftp.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_virtual_server/f5_virt_ue_v4_tftp.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_virtual_server/f5_virt_ue_v4_rtsp.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_virtual_server/f5_virt_ue_v4_pptp.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_virtual_server/f5_virt_ue_v6.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_virtual_server/f5_virt_ue_v6_ftp.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_virtual_server/f5_virt_ue_v6_tftp.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_virtual_server/f5_virt_ue_v6_rtsp.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_afm/f5_afm_apply_policy.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_command/f5_gtac_apply.yml statically imported: /home/ja702x/roles/f5base/tasks/bigip_config/f5_config_save.yml

PLAYBOOK: f5.yml **** 1 plays in f5.yml

PLAY [zrdm5bfcgi01] ***** META: ran handlers

TASK [f5base : Build FORWARDER-IPV6 Virtual Server] ***** task path: /home/ja702x/roles/f5base/tasks/bigip_virtual_server/f5_virt_ue_v6.yml:2 Using module file /home/ja702x/library/bigip_virtual_server.py Using module file /home/ja702x/library/bigip_virtual_server.py

ESTABLISH LOCAL CONNECTION FOR USER: ja702x ESTABLISH LOCAL CONNECTION FOR USER: ja702x EXEC /bin/sh -c '/usr/bin/python && sleep 0' EXEC /bin/sh -c '/usr/bin/python && sleep 0' ok: [zf5004 -> localhost] => { "address_translation": false, "changed": false, "invocation": { "module_args": { "address_translation": null, "all_profiles": [ "fastL4" ], "default_persistence_profile": null, "description": "UE to Internet IPV6 forwarder", "destination": "::", "disabled_vlans": null, "enabled_vlans": [ "SGI-PROTECTED" ], "fallback_persistence_profile": null, "irules": null, "metadata": null, "name": "FORWARDER-IPV6", "partition": "Common", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "policies": null, "pool": null, "port": 0, "port_translation": null, "profiles": [ "fastL4" ], "provider": { "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "server": "1.1.1.1", "server_port": 443, "ssh_keyfile": null, "timeout": 10, "transport": "rest", "user": "admin", "validate_certs": false }, "server": "1.1.1.1", "server_port": 443, "snat": "automap", "source": null, "state": "present", "transport": "rest", "user": "admin", "validate_certs": false } }, "port_translation": false } ok: [zf5003 -> localhost] => { "address_translation": false, "changed": false, "invocation": { "module_args": { "address_translation": null, "all_profiles": [ "fastL4" ], "default_persistence_profile": null, "description": "UE to Internet IPV6 forwarder", "destination": "::", "disabled_vlans": null, "enabled_vlans": [ "SGI-PROTECTED" ], "fallback_persistence_profile": null, "irules": null, "metadata": null, "name": "FORWARDER-IPV6", "partition": "Common", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "policies": null, "pool": null, "port": 0, "port_translation": null, "profiles": [ "fastL4" ], "provider": { "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "server": "1.1.1.2", "server_port": 443, "ssh_keyfile": null, "timeout": 10, "transport": "rest", "user": "admin", "validate_certs": false }, "server": "1.1.1.2", "server_port": 443, "snat": "automap", "source": null, "state": "present", "transport": "rest", "user": "admin", "validate_certs": false } }, "port_translation": false } META: ran handlers META: ran handlers PLAY RECAP ****************************************************************************************************************************************************************************************************************************** zrdm5bfcgi01cgi003 : ok=1 changed=0 unreachable=0 failed=0 zrdm5bfcgi01cgi004 : ok=1 changed=0 unreachable=0 failed=0

caphrim007 commented 6 years ago

@rajeshanne I dont see an error in that output?

Can you provide a simple task that illustrates the problem? You do not need to include any internal addresses or names.

rajeshanne commented 6 years ago

Play:

name: Build {{ virt_v4_forwarder_ftp }} Virtual Server bigip_virtual_server: state: present name: "{{ virt_v4_forwarder_ftp }}" description: "{{ virt_v4_forwarder_ftp_desc }}" destination: "{{ virt_v4_forwarder_ftp_dest }}" port: "{{ virt_v4_forwarder_ftp_port }}" all_profiles:
- "{{ virt_v4_forwarder_ftp_profile_0 }}"
- "{{ virt_v4_forwarder_ftp_profile_1 }}" enabled_vlans: "{{ trusted_vlan }}" snat: "automap" server: "{{ ansible_host }}" user: "{{ username }}" password: "{{ password }}" validate_certs: "no" delegate_to: localhost

vars:

virt_v4_forwarder_ftp: FORWARDER-FTP-IPV4 virt_v4_forwarder_ftp_desc: "UE to Internet IPV4 forwarder for FTP" virt_v4_forwarder_ftp_dest: "0.0.0.0" virt_v4_forwarder_ftp_port: "ftp" virt_v4_forwarder_ftp_profile_0: "tcp" virt_v4_forwarder_ftp_profile_1: "ftp"

error: fatal: [f5004 -> localhost]: FAILED! => {"changed": false, "msg": "argument port is of type <type 'str'> and we were unable to convert to int: invalid literal for int() with base 10: 'ftp'"} fatal: [f5003 -> localhost]: FAILED! => {"changed": false, "msg": "argument port is of type <type 'str'> and we were unable to convert to int: invalid literal for int() with base 10: 'ftp'"}

From: Tim Rupp notifications@github.com Sent: Tuesday, March 20, 2018 1:43 PM To: F5Networks/f5-ansible Cc: rajeshanne; Mention Subject: Re: [F5Networks/f5-ansible] Virtual server play not accepting string type for port (#675)

@rajeshannehttps://github.com/rajeshanne I dont see an error in that output?

Can you provide a simple task that illustrates the problem? You do not need to include any internal addresses or names.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/F5Networks/f5-ansible/issues/675#issuecomment-374749601, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Abdj1j-_3Qt5v1jPucqPrBFYwq-q7kewks5tgWnfgaJpZM4Sya4Q.

rajeshanne commented 6 years ago

From: Tim Rupp notifications@github.com Sent: Tuesday, March 20, 2018 1:43 PM To: F5Networks/f5-ansible Cc: rajeshanne; Mention Subject: Re: [F5Networks/f5-ansible] Virtual server play not accepting string type for port (#675)

@rajeshannehttps://github.com/rajeshanne I dont see an error in that output?

Can you provide a simple task that illustrates the problem? You do not need to include any internal addresses or names.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/F5Networks/f5-ansible/issues/675#issuecomment-374749601, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Abdj1j-_3Qt5v1jPucqPrBFYwq-q7kewks5tgWnfgaJpZM4Sya4Q.

caphrim007 commented 6 years ago

@rajeshanne this is expected behavior. the port takes a port number, not the name of a service.

caphrim007 commented 6 years ago

If you want this changed (so that it takes a service name) the list that i'm willing to accept is the same list that tmui presents.

screen shot 2018-03-20 at 3 27 44 pm

lemme know if this is sufficient

rajeshanne commented 6 years ago

Hello Tim,

 we can configure  port to be ftp via cli or gui fine. It is hard to to define ports for complex alg protocols like ftp. It should let accept string is I what i feel.

Thanks, Rajesh

From: Tim Rupp notifications@github.com Sent: Tuesday, March 20, 2018 3:28 PM To: F5Networks/f5-ansible Cc: rajeshanne; Mention Subject: Re: [F5Networks/f5-ansible] Virtual server play not accepting string type for port (#675)

@rajeshannehttps://github.com/rajeshanne this is expected behavior. the port takes a port number, not the name of a service.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/F5Networks/f5-ansible/issues/675#issuecomment-374778905, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Abdj1nED7tQXrXDl1m-uxtnbNkDBEhOtks5tgYKNgaJpZM4Sya4Q.

caphrim007 commented 6 years ago

@rajeshanne is the service list in tmui sufficient? or would you want more.

rajeshanne commented 6 years ago

Sufficient Tim.

From: Tim Rupp notifications@github.com Sent: Tuesday, March 20, 2018 3:33 PM To: F5Networks/f5-ansible Cc: rajeshanne; Mention Subject: Re: [F5Networks/f5-ansible] Virtual server play not accepting string type for port (#675)

@rajeshannehttps://github.com/rajeshanne is the service list in tmui sufficient? or would you want more.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/F5Networks/f5-ansible/issues/675#issuecomment-374780160, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Abdj1hvwcryp8Fm6xufPF60DcummWsOyks5tgYPFgaJpZM4Sya4Q.

delgadillo22 commented 6 years ago

Enhancement, not bug.

F5Networks / f5-ansible