F5Networks / f5-appsvcs-extension

F5 BIG-IP Application Services 3 Extension
Apache License 2.0
169 stars 54 forks source link

"remark": not working on /fast/applications endpoint #765

Open DahlPatric opened 1 year ago

DahlPatric commented 1 year ago

Environment

Summary

When posting declaration containing "remark:" to FAST endpoint /mgmt/shared/fast/applications receiving error "declaration lacks valid 'id' property". Doing same towards /mgmt/shared/appsvcs/declare working fine.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Submit the following declaration:

    {
    "$schema": "https://raw.githubusercontent.com/F5Networks/f5-appsvcs-extension/master/schema/latest/as3-schema.json",
    "class": "AS3",
    "action": "deploy",
    "persist": true,
    "declaration": {
      "class": "ADC",
      "schemaVersion": "3.36.0",
      "id": "urn:uuid:fa98c3f0-3d29-4733-815a-fddc9e7b427a",
      "label": "Version 1.0",
      "remark": "Standard HTTPS application with predictive-node pool",
      "constants": {
        "class": "Constants",
        "timestamp": "2023-05-11T13:59:00Z",
        "version": 1.0
      },
      "App1": {
        "class": "Tenant",
        "defaultRouteDomain": 0,
        "my-app": {
          "class": "Application",
          "template": "generic",
          "App1": {
            "class": "Service_HTTPS",
            "remark": "Application-name",
            "clientTLS": [
              {
                "bigip": "/Common/serverssl"
              }
            ],
            "serverTLS": [
              {
                "bigip": "/Common/wildcard.domain.net"
              }
            ],
            "virtualAddresses": [
              "1.1.1.1"
            ],
            "pool": "p-App1-80",
            "persistenceMethods": [
               "cookie"
            ],
            "securityLogProfiles": [
              {
                "bigip": "/Common/Log illegal requests"
              }
            ]
          },  
          "p-App1-80": {
            "class": "Pool",
            "loadBalancingMode": "predictive-node",
            "monitors": [
              "https"
            ],
            "members": [
              {
                "servicePort": 80,
                "serverAddresses": ["3.3.3.3"],
                "enable": true,
                "adminState": "enable",
                "addressDiscovery": "static"
              }
            ]
          }
        }
      }
    }
    }
  2. Observe the following error response:

    {
    "id": "572e1b5f-6c4a-4e68-ae80-7435538b808e",
    "results": [
        {
            "code": 422,
            "declarationFullId": "",
            "message": "declaration lacks valid 'id' property"
        }
    ],
    "declaration": {}
    }

Expected Behavior

Should be working same as for appsvcs endpoint. Remarks should update Description text in BigIP

Actual Behavior

"Remark": is not working.

sunitharonan commented 1 year ago

Thank you @DahlPatric . In order to prioritize and understand the issue better, please reach out to us at automation_toolchain_pm@f5.com