search

F5Networks / f5-appsvcs-extension

F5 BIG-IP Application Services 3 Extension
Apache License 2.0
163 stars 52 forks source link

cosmetic issues in in-progress tasks returned payload #828

Open amolari opened 1 month ago

amolari commented 1 month ago

Environment

Summary

Posting an async declaration the following payload is returned:

{
  "id": "dc5c5f6d-1e86-4428-b643-e6da3a9b72ed",
  "results": [
    {
      "message": "Declaration successfully submitted",
      "tenant": "",
      "host": "",
      "runTime": 0,
      "code": 0,
      "declarationId": "691121"
    }
  ],
  "declaration": {},
  "selfLink": "https://localhost/mgmt/shared/appsvcs/task/dc5c5f6d-1e86-4428-b643-e6da3a9b72ed"
}

when querying the task-id, if the task is in-progress we get the following payload returned:

{
  "id": "dc5c5f6d-1e86-4428-b643-e6da3a9b72ed",
  "results": [
    {
      "message": "in progress",
      "tenant": "",
      "host": "",
      "runtTime": 0,
      "code": 0
    }
  ],
  "declaration": {}
}

Issues:

  1. typo in runtTime => should be runTime (code: https://github.com/F5Networks/f5-appsvcs-extension/blob/91e3b2dd2be4369b95eaea039899bd2174f48830/src/lib/asyncHandler.js#L98)
  2. declarationId is missing
  3. selfLink is missing
mdditt2000 commented 1 month ago

@amolari thanks for opening this cosmetic issue. Easy fix on your end

--- Change "runtTime": 0, to runTime

Added AUTOTOOL-4353

mdditt2000 commented 2 weeks ago

@amolari picked up in the current sprint